phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2470) Skip overlapped scan left after StaleRegionBoundaryCacheException
Date Thu, 03 Dec 2015 20:57:10 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038572#comment-15038572
] 

James Taylor commented on PHOENIX-2470:
---------------------------------------

[~ankit.singhal] - please spin up a patch. Is this isolated to local indexes or is it an issue
across the board? A unit test would be good too (but understandably difficult). See SkipScanAfterManualSplitIT.testManualSplit()
for an example.

> Skip overlapped scan left after StaleRegionBoundaryCacheException
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-2470
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2470
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>
> We should skip the stale scanners because of two reasons:-
> 1. For local indexing , they can generate duplicate result if the compaction didn't complete
for the merged region.
> 2. Stale scanners which may result empty but may impact performance.
> For eg:- skipping scanners which has overlap with the previous succesfull scanner
> In BaseResultIterators.java 
> {code}
> +                        if (isLocalIndex && previousScan != null
> +                                && ((!isReverse && Bytes.compareTo(scanPair.getFirst().getStartRow(),
> +                                        previousScan.getStopRow()) < 0)
> +                                || (isReverse && Bytes.compareTo(scanPair.getFirst().getStartRow(),
> +                                        previousScan.getStopRow()) > 0)
> +                                || (scanPair.getFirst().getAttribute(EXPECTED_UPPER_REGION_KEY)
!= null
> +                                        && previousScan.getAttribute(EXPECTED_UPPER_REGION_KEY)
!= null
> +                                        && Bytes.compareTo(scanPair.getFirst().getAttribute(EXPECTED_UPPER_REGION_KEY),
> +                                                previousScan.getAttribute(EXPECTED_UPPER_REGION_KEY))
== 0))) {
> +
> +                            continue;
>                          }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message