phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankit Singhal (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-2470) Skip overlapped scan left after StaleRegionBoundaryCacheException
Date Sun, 06 Dec 2015 12:08:10 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ankit Singhal updated PHOENIX-2470:
-----------------------------------
    Attachment: PHOENIX-2470.patch

[~giacomotaylor], it seems to be with local index only for now .
Because we update the endKey for local index only after we discover the stale region boundaries.

In BaseResultIterators.java
{code}
if (isLocalIndex) {
                                endKey = oldScan.getAttribute(EXPECTED_UPPER_REGION_KEY);
                            }
{code}


PFA, patch for the code change.

I'll upload the unit/Integration test case soon.


> Skip overlapped scan left after StaleRegionBoundaryCacheException
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-2470
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2470
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>         Attachments: PHOENIX-2470.patch
>
>
> We should skip the stale scanners because of two reasons:-
> 1. For local indexing , they can generate duplicate result if the compaction didn't complete
for the merged region.
> 2. Stale scanners which may result empty but may impact performance.
> For eg:- skipping scanners which has overlap with the previous succesfull scanner
> In BaseResultIterators.java 
> {code}
> +                        if (isLocalIndex && previousScan != null
> +                                && ((!isReverse && Bytes.compareTo(scanPair.getFirst().getStartRow(),
> +                                        previousScan.getStopRow()) < 0)
> +                                || (isReverse && Bytes.compareTo(scanPair.getFirst().getStartRow(),
> +                                        previousScan.getStopRow()) > 0)
> +                                || (scanPair.getFirst().getAttribute(EXPECTED_UPPER_REGION_KEY)
!= null
> +                                        && previousScan.getAttribute(EXPECTED_UPPER_REGION_KEY)
!= null
> +                                        && Bytes.compareTo(scanPair.getFirst().getAttribute(EXPECTED_UPPER_REGION_KEY),
> +                                                previousScan.getAttribute(EXPECTED_UPPER_REGION_KEY))
== 0))) {
> +
> +                            continue;
>                          }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message