phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2528) Pherf JVM doesn't exit due to un-closed ThreadPool
Date Tue, 15 Dec 2015 01:51:46 GMT


Josh Elser commented on PHOENIX-2528:

bq. Do you think the threads should be marked as daemon threads too?

Personally, no, I don't. Marking them as daemon doesn't make sense for how they're being used.
I'd say it's better to make sure we understand how they're used than to err on the side of
marking them as daemon.

> Pherf JVM doesn't exit due to un-closed ThreadPool
> --------------------------------------------------
>                 Key: PHOENIX-2528
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 4.7.0
>         Attachments: PHOENIX-2528.patch
> In trying to use the pherf tool in "cluster" mode, the invocation of {{Pherf}} never
exited. I had removed a {{System.exit(0)}} already because it was suppressing an Exception.
> The JVM never exited because there were a number of threads (8) still running and not
marked as daemon. After a while, I finally tracked down these threads to {{WriteWorkload}}
which didn't bother to close the pool.
> I believe the System.exit was forcing the JVM to exit instead of letting it exit naturally.

This message was sent by Atlassian JIRA

View raw message