phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2531) Phoenix thin-client jar has incorrect META-INF/services/java.sql.Driver file
Date Tue, 15 Dec 2015 23:34:46 GMT


Nick Dimiduk commented on PHOENIX-2531:

I checked both my builds of 4.6.1-SNAPSHOT and HDP's; both contain {{org.apache.calcite.avatica.remote.Driver}},
not {{org.apache.phoenix.queryserver.client.Driver}}. It's not a regression. Anyway, if PQS
still works with this change, +1 as well.

> Phoenix thin-client jar has incorrect META-INF/services/java.sql.Driver file
> ----------------------------------------------------------------------------
>                 Key: PHOENIX-2531
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 4.7.0
>         Attachments: PHOENIX-2531.patch
> Trying to hook up the thin-client to pherf, I was having some troubles with being unable
to find the thin-client Driver. I knew that we should be getting it loaded by the service
definition contained in the jar {{META-INF/services/java.sql.Driver}}.
> Upon inspection of the "normal" jar produced by {{phoenix-server-client}}, the contents
of the file were as we expect {{org.apache.phoenix.queryserver.client.Driver}}. However, the
top-level "thin-client" jar we bundle in the tarball had a value of {{org.apache.calcite.avatica.remote.Driver}}
> It seems like when we built {{phoenix-$VERSION-thin-client.jar}} (jar-with-dependencies
is all it is, really), Avatica's {{META-INF/services/java.sql.Driver}} was overwriting the
copy we had in {{phoenix-server-client/src/main/resources}}. I'm not sure how/why we didn't
notice this yet (for example, why did work?), but it's definitely busted for
how it _should_ work.
> It's a simple enough fix to explicitly set the file in the assembly descriptor.

This message was sent by Atlassian JIRA

View raw message