phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)
Date Tue, 07 Jun 2016 15:49:21 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318724#comment-15318724
] 

Josh Elser commented on PHOENIX-2535:
-------------------------------------

bq. is it ready to be committed?

No, not quite, but I think it's close.

I left some comments on the the [PR|https://github.com/apache/phoenix/pull/159/files]. The
queryserver and queryserver-client artifacts were being pulled into phoenix-client which I
believe is wrong and the phoenix-queryserver jars are missing the lib directory of the bin
tarball. I diffed the contents of the lib directory with an installation of master from a
few weeks ago and it looks fine aside from those missing jars.

I also left two super minor requests for better descriptions in the new poms.

> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, PHOENIX-2535-3.patch,
PHOENIX-2535-4.patch, PHOENIX-2535-5.patch, PHOENIX-2535-6.patch, PHOENIX-2535-7.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency conflicts at
the run time. We are seeing more of Phoenix JDBC client being used in Storm topologies and
other settings where guava versions become a problem. 
> I think we can do a parallel artifact for the thick client with shaded dependencies and
also using shaded hbase. For thin client, maybe shading should be the default since it is
new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message