phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)
Date Wed, 08 Jun 2016 15:45:21 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320775#comment-15320775
] 

ASF GitHub Bot commented on PHOENIX-2535:
-----------------------------------------

Github user ss77892 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/159#discussion_r66281559
  
    --- Diff: phoenix-queryserver/pom.xml ---
    @@ -24,6 +26,50 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-failsafe-plugin</artifactId>
           </plugin>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-shade-plugin</artifactId>
    +        <executions>
    +          <execution>
    +            <id>query-server</id>
    +            <phase>package</phase>
    +            <goals>
    +              <goal>shade</goal>
    +            </goals>
    +            <configuration>
    +              <finalName>phoenix-${project.version}-queryserver</finalName>
    +              <shadedArtifactAttached>false</shadedArtifactAttached>
    +              <promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    +              <shadeTestJar>false</shadeTestJar>
    +              <artifactSet>
    +                <includes>
    +                  <include>org.apache.phoenix:phoenix-server</include>
    --- End diff --
    
    Oh. Thanks. The default artifact for module is added automatically, so we can just remove
that at all. I will check. Will do a fresh look on all poms after all those moving back and
forth. 


> Create shaded clients (thin + thick) 
> -------------------------------------
>
>                 Key: PHOENIX-2535
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2535
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Sergey Soldatov
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, PHOENIX-2535-3.patch,
PHOENIX-2535-4.patch, PHOENIX-2535-5.patch, PHOENIX-2535-6.patch, PHOENIX-2535-7.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency conflicts at
the run time. We are seeing more of Phoenix JDBC client being used in Storm topologies and
other settings where guava versions become a problem. 
> I think we can do a parallel artifact for the thick client with shaded dependencies and
also using shaded hbase. For thin client, maybe shading should be the default since it is
new? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message