phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf
Date Tue, 21 Jun 2016 21:58:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342834#comment-15342834
] 

Enis Soztutar commented on PHOENIX-2931:
----------------------------------------

bq. The intention of this print statement was when users did not provide connection string
in the command line, we could see it was getting from default explicitly. Of cause this info
can be found from connection starting up print.
You cannot have System.out.println() as a debug statement. Please remove. 
bq. jdbc:phoenix:null came from psql command line if we did not provide the connection string.
jdbc:phoenix;test=true came from PhoenixEmbeddedDriverTest.
You cannot have production code having test-related code like this. We should not pass "null"
as the connection string, it should be empty string. 
bq. This part of code is used by psql.py. If we did not provide connection string in the command
line, the first arg would be a file. There is no guarantee the first one is a connection string.
We already check whether it is a file or not above, no? The suggestion simplifies the logic
for handling the case where arg does not end with .csv or .sql. 

> Phoenix client asks users to provide configs in cli that are present on the machine in
hbase conf
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2931
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2931
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2931-v1.patch, PHOENIX-2931-v2.patch, PHOENIX-2931.patch
>
>
> Users had complaints on running commands like
> {code}
> phoenix-sqlline pre-prod-poc-2.novalocal,pre-prod-poc-10.novalocal,pre-prod-poc-1.novalocal:/hbase-unsecure
service-logs.sql
> {code}
> However the zookeeper quorum and the port are available in hbase configs. Phoenix should
read these configs from the system instead of having the user supply them every time.
> What we can do is to introduce a keyword "default". If it is specified, default zookeeper
quorum and port will be taken from hbase configs. Otherwise, users can specify their own.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message