phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2949) Fix estimated region size when checking for serial query
Date Wed, 08 Jun 2016 09:57:21 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320316#comment-15320316
] 

Hadoop QA commented on PHOENIX-2949:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12808862/PHOENIX-2949_v1.patch
  against master branch at commit b2e3018c8799f326f453983f66eaf6c4291acd0f.
  ATTACHMENT ID: 12808862

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 31 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 7 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +         * the limit's worth of data is less than the threshold bytes provided in QueryServices.QUERY_PARALLEL_LIMIT_THRESHOLD
+            estimatedParallelThresholdBytes = services.getProps().getLong(HConstants.HREGION_MAX_FILESIZE,
+        long limitThreshold = services.getProps().getLong(QueryServices.QUERY_PARALLEL_LIMIT_THRESHOLD,
+                "With LIMIT=" + perScanLimit + ", estimated row size=" + estRowSize + ",
limitThreshold="
+    public static final String QUERY_PARALLEL_LIMIT_THRESHOLD = "phoenix.query.parallelThresholdBytes";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CsvBulkLoadToolIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/388//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/388//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/388//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/388//console

This message is automatically generated.

> Fix estimated region size when checking for serial query
> --------------------------------------------------------
>
>                 Key: PHOENIX-2949
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2949
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2949.patch, PHOENIX-2949_v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message