phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3193) Tracing UI cleanup - final tasks before GSoC pull request
Date Sun, 28 Aug 2016 21:23:20 GMT


ASF GitHub Bot commented on PHOENIX-3193:

GitHub user AyolaJayamaha opened a pull request:

    PHOENIX-3193 Tracing UI cleanup 


You can merge this pull request into a Git repository by running:

    $ git pull phoenix-tracing

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #202
commit a0338442f6dd1c1a2a9219459111dbc7afa48687
Author: ayolajayamaha <>
Date:   2016-06-14T09:44:01Z

    adding trace on and off

commit 5e3fbf9a5fc46e7b94e306ee76ebd95e7c45d19e
Author: ayolajayamaha <>
Date:   2016-06-17T18:04:25Z

    Adding search by description,hostname

commit a6419ac2e3ecef6c73401911db59b7fab2c09aac
Author: ayolajayamaha <>
Date:   2016-06-18T01:51:14Z

    adding query

commit 95a6d7766da3a71270edd83ae2a65a3cee9c595e
Author: ayolajayamaha <>
Date:   2016-06-18T11:07:26Z

    ui router change

commit 041d8a66bb28a76084510036221f14d5367478c3
Author: ayolajayamaha <>
Date:   2016-06-18T11:08:04Z

    removing phoenix connection

commit 66565c6ad9faf9cf4ece4c588777ee059fe46cc7
Author: ayolajayamaha <>
Date:   2016-06-20T12:53:56Z

    search trace

commit a8b18c958c531c11a7bf1ef79547822769fa05cf
Author: ayolajayamaha <>
Date:   2016-06-20T16:35:05Z


commit 2d47c830038da15de83486f577b1f1ae7cb1b39f
Author: ayolajayamaha <>
Date:   2016-06-20T17:48:30Z

    adding timeline and list and binding

commit 0f89a27f1ba0b44f5320b8b3ecb424a945e60f01
Author: ayolajayamaha <>
Date:   2016-06-21T11:38:56Z

    Query Builder List and Timeline

commit aa9d54f69fda194fafdf519e3497b6fc66bb8266
Author: ayolajayamaha <>
Date:   2016-06-21T17:05:47Z

    Dependency Tree

commit ef0cf8219953a2a5153d6594fdbb424d239fbdfb
Author: ayolajayamaha <>
Date:   2016-06-21T17:18:56Z

    adding tests

commit 4a5f6ed754075750cde5ed3e60af53462a534b7d
Author: ayolajayamaha <>
Date:   2016-06-22T08:53:13Z

    Trace Distribution

commit 133343e229a91df0afcbad70b32013cb96f8028f
Author: ayolajayamaha <>
Date:   2016-06-22T12:41:23Z

    Trace Distribution

commit ab8cf26ea5a36e1b63f5a5fae54bbd93ea5996b9
Author: ayolajayamaha <>
Date:   2016-07-12T11:18:15Z

    zookeeper port

commit 7181dd4a1405a54a810c6e2a0b8c4894def52b08
Author: ayolajayamaha <>
Date:   2016-07-12T17:01:55Z

    fixing zookeeper port/host

commit b3486c0cf27a07723da7286f60257e71aeb4305e
Author: ayolajayamaha <>
Date:   2016-07-19T17:36:01Z

    fixing zookeeper port

commit a2d27c7d797835bda993be2e24ace55ead7c3e23
Author: ayolajayamaha <>
Date:   2016-07-20T17:30:46Z

    fixing the distribution chart types

commit 1416c201ed21dbc7c69114979f0b3feeb5324675
Author: ayolajayamaha <>
Date:   2016-08-04T17:24:51Z

    changing the UI menus and fixing the json response-rest

commit af2779d6deba2e0c172d308b697faaaccecfaaf5
Author: ayolajayamaha <>
Date:   2016-08-08T10:29:48Z

    Adding trace distribution by description

commit e379790b206bcc05b5208909145952ef80818bb7
Author: ayolajayamaha <>
Date:   2016-08-08T14:43:00Z

    Adding custom tooltip for UI

commit 945845055711ac911137c53243627ff0a6281d78
Author: ayolajayamaha <>
Date:   2016-08-08T15:38:38Z

    updating the searchtrace controller- distribution types

commit 69bc3b06392acb57736f954ea59b24ce27002f9e
Author: ayolajayamaha <>
Date:   2016-08-14T18:58:43Z

    adding mock span for timeline

commit 30fe0caa86e138fe9340d575ab8739072550c0c1
Author: ayolajayamaha <>
Date:   2016-08-17T13:05:18Z

    fixing bug - timeline alert msg

commit 5fc221c9950f944fb04cd919f8963a5e9a462c49
Author: ayolajayamaha <>
Date:   2016-08-18T09:00:07Z

    remove line chart and list page reformating

commit 1944d0f6e403e682d1b941949a52675e21b7241c
Author: ayolajayamaha <>
Date:   2016-08-18T13:09:54Z

    changing the text in chart axis

commit c6d7d17afa2c6b7b1c39bef718cda807b296cf38
Author: ayolajayamaha <>
Date:   2016-08-18T17:04:44Z

    fixing timeline label

commit 54fc179488b8b9fef4a5ac6dc400db95270379f3
Author: ayolajayamaha <>
Date:   2016-08-23T05:12:07Z

    reading a json object

commit 85fb53c53072e4cec05c846cc9bcee9e2ae7d43f
Author: ayolajayamaha <>
Date:   2016-08-28T20:56:52Z

    adding submodules

commit 36487318b4f1d98926dd75182d5d5bf4eb0b7a23
Author: ayolajayamaha <>
Date:   2016-08-28T21:01:27Z

    adding submodules

commit 7d35e92b2dad206431497a2c8f3c09d09aed22dc
Author: ayolajayamaha <>
Date:   2016-08-28T21:05:54Z

    adding submodules


> Tracing UI cleanup - final tasks before GSoC pull request
> ---------------------------------------------------------
>                 Key: PHOENIX-3193
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Mujtaba Chohan
>            Assignee: Nishani 
> Points from GSoC presentation on tracing imporvements:
> *Tracing UI*
> * Remove line chart 
> * In list page, run query with description, start_time, (end_time-start_time) duration
from T where trace_id = ?
> * More space for descriptions on bar chart. Wrap if necessary
> * Label for X axis on timeline sometime again start from 0, if X axis is in seconds then
it should not rollover after 60 seconds unless minutes are also shown
> * X-axis labeled as Node on various charts, but should be Percentage
> *Zipkin*
> * Flip zipkin chart on vertical axis with arrows going other way. So start from the top
level root on the leftmost side and work toward children on the right.
> * Ask zipkin community if there's a way to tell it that date/time is in milliseconds.
> *Overall*
> * Please put together a pull request to the phoenix project to add the zipkiin work you've
done to the OS project. Ideally, include the zipkin work in the phoenix-tracing module and
call it phoeix-tracing. Only if there is some major hurdle, create a new module.
> * Test with trace_ids that have multiple spans with duration (end_time - start_time)
> 5 ms and verify that UI and Zipkin output shows the correct corresponding timeline

This message was sent by Atlassian JIRA

View raw message