phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2890) Extend IndexTool to allow incremental index rebuilds
Date Wed, 30 Nov 2016 09:20:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708032#comment-15708032
] 

ASF GitHub Bot commented on PHOENIX-2890:
-----------------------------------------

Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/210#discussion_r90192895
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java
---
    @@ -217,39 +223,47 @@ public void testSecondaryIndex() throws Exception {
     
                 assertFalse(rs.next());
     
    -            conn.createStatement().execute(String.format("DROP INDEX  %s ON %s", indxTable,
fullTableName));
    +           // conn.createStatement().execute(String.format("DROP INDEX  %s ON %s", indxTable,
fullTableName));
    --- End diff --
    
    We can remove this commented code.


> Extend IndexTool to allow incremental index rebuilds
> ----------------------------------------------------
>
>                 Key: PHOENIX-2890
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2890
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-2890.patch, PHOENIX-2890_wip.patch
>
>
> Currently , IndexTool is used for initial index rebuild but I think we should extend
it to be used for recovering index from last disabled timestamp too. 
> In general terms if we run IndexTool on already existing/new index, then it should follow
the same semantics as followed by background Index rebuilding thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message