phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in functions as Calcite functions
Date Thu, 01 Dec 2016 16:28:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712402#comment-15712402
] 

ASF GitHub Bot commented on PHOENIX-3355:
-----------------------------------------

Github user lomoree commented on the issue:

    https://github.com/apache/phoenix/pull/222
  
    1. There are still a number of cases that don't pass. Many of them are due to existing
features not being supported, and many are due to other issues within Calcite-Phoenix. I have
compiled a list of the major common issues though:
    - No differentiation between the regex functions (String based and Byte based)
    - Invert and MD5 Function don't work (phoenix doesn't supply the correct arguments in
annotation)
    - Type matching doesn't work on input arguments (date/timestamp)
    - Timezone parameter doesn't work properly in ToDateFunction (basic cases work, but custom
timezones do not act as expected)
    - Array constructors are not supported (another issue entirely)
    
    2. I believe you're referring to those in PhoenixScalarFunction, createBuiltinFunctions()
and evaluateReturnType()? In the case of createBuiltinFunctions() it makes sense to be in
PhoenixScalarFunction since it create instances of that class. We could move evaluateReturnType()
to PhoenixSchema since it has more generic behavior, but I'm not entirely convinced that it
should move.


> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>         Attachments: PHOENIX-3355.function_constructor.patch, PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message