phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3355) Register Phoenix built-in functions as Calcite functions
Date Fri, 02 Dec 2016 00:10:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713492#comment-15713492
] 

ASF GitHub Bot commented on PHOENIX-3355:
-----------------------------------------

Github user maryannxue commented on the issue:

    https://github.com/apache/phoenix/pull/222
  
    2. We'll leave it then. I think the future solution can be either 1) add as built-in funcs
in Calcite; or 2) add type derivation mechanism for UDFs in Calcite.
    3. See "getAdjustedTime" in CalciteUtils then. You might need to do something similar
somewhere, or this method is doing something wrong in the first place.
    
    Please go ahead with 1, 3 and 6, but feel free to leave out 3 if it doesn't work out easily
for you.


> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>         Attachments: PHOENIX-3355.function_constructor.patch, PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message