phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3488) Support COUNT(DISTINCT x) in Phoenix-Calcite Integration
Date Thu, 01 Dec 2016 23:56:58 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713467#comment-15713467
] 

ASF GitHub Bot commented on PHOENIX-3488:
-----------------------------------------

Github user lomoree commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/223#discussion_r90563623
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
---
    @@ -899,9 +899,6 @@ public static boolean isConvertible(Aggregate input) {
             if (input.getGroupSets().size() > 1)
                 return false;
             
    -        if (input.containsDistinctCall())
    --- End diff --
    
    @maryannxue added a commit to detect for any distinct calls that aren't of type COUNT.
Thanks!


> Support COUNT(DISTINCT x) in Phoenix-Calcite Integration
> --------------------------------------------------------
>
>                 Key: PHOENIX-3488
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3488
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eric Lomore
>            Assignee: Eric Lomore
>              Labels: calcite
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message