phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3745) SortMergeJoin might incorrectly override the OrderBy of LHS or RHS
Date Mon, 20 Mar 2017 17:19:41 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933102#comment-15933102
] 

Hadoop QA commented on PHOENIX-3745:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12859577/PHOENIX-3745_v1.patch
  against master branch at commit 8093d10f1a481101d6c93fdf0744ff15ec48f4aa.
  ATTACHMENT ID: 12859577

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 11 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            sql="select /*+ USE_SORT_MERGE_JOIN */ a.aid,b.code from (select aid,age
from "+tableName1+" where age >=11 and age<=33) a inner join "+
+            sql="select /*+ USE_SORT_MERGE_JOIN */ a.aid,b.code from (select aid,age from
"+tableName1+" where age >=11 and age<=33) a inner join "+
+            sql="select /*+ USE_SORT_MERGE_JOIN */ a.aid,b.codesum from (select aid,sum(age)
agesum from "+tableName1+" where age >=11 and age<=33 group by aid order by agesum limit
3) a inner join "+
+                "(select bid,sum(code) codesum from "+tableName2+" group by bid order by
codesum limit 2) b on a.aid=b.bid ";
+                "(select a.aid,b.code from "+tableName1+" a inner join "+tableName2+" b on
a.aid=b.bid where b.code >=44 and b.code<=66 order by b.code limit 3) t1 inner join
"+
+                "(select a.aid,c.region from "+tableName1+" a inner join "+tableName3+" c
on a.aid=c.cid where c.region>=77 and c.region<=99 order by c.region desc limit 1) t2
on t1.aid=t2.aid";
+                "(select a.aid,sum(b.code) codesum from "+tableName1+" a inner join "+tableName2+"
b on a.aid=b.bid where b.code >=44 and b.code<=66 group by a.aid order by codesum limit
3) t1 inner join "+
+                "(select a.aid,sum(c.region) regionsum from "+tableName1+" a inner join "+tableName3+"
c on a.aid=c.cid where c.region>=77 and c.region<=99 group by a.aid order by regionsum
desc limit 2) t2 on t1.aid=t2.aid";
+                        SubselectRewriter.applyPostFilters(subselect, preFilters, tableNode.getAlias()),
+    public static SelectStatement applyOrderBy(SelectStatement statement, List<OrderByNode>
orderBy, String subqueryAlias,TableNode tableNode) throws SQLException {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RenewLeaseIT

     {color:red}-1 core zombie tests{color}.  There are 4 zombie test(s): 

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/807//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/807//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/807//console

This message is automatically generated.

> SortMergeJoin might incorrectly override the OrderBy of LHS or RHS
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3745
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3745
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.0
>            Reporter: chenglei
>            Assignee: chenglei
>         Attachments: PHOENIX-3745_v1.patch
>
>
> Let us look a simple test case:
> h4. 1. Create two tables
>  {noformat}
>    CREATE TABLE IF NOT EXISTS MERGE1 (
>          AID INTEGER PRIMARY KEY
>          AGE INTEGER
>     );
>   CREATE TABLE IF NOT EXISTS MERGE2 (
>          BID INTEGER PRIMARY KEY,
>          CODE INTEGER
>   );
>  {noformat}
>  h4. 2. Upsert values
>  {noformat}
>           UPSERT INTO MERGE1(AID,AGE) VALUES (1,11);
>           UPSERT INTO MERGE1(AID,AGE) VALUES (2,22);
>           UPSERT INTO MERGE1 (AID,AGE) VALUES (3,33);
>           UPSERT INTO MERGE2 (BID,CODE) VALUES (1,66);
>           UPSERT INTO MERGE2 (BID,CODE) VALUES (2,55);
>           UPSERT INTO MERGE2 (BID,CODE) VALUES (3,44);
>  {noformat}
>  h4. 3. Execute query
>  {noformat}
>     select /*+ USE_SORT_MERGE_JOIN */ a.aid,b.code from
>      (select aid,age from merge1  where age >=11 and age<=33) a inner join 
>      (select bid,code from merge2  order by code limit 1) b on a.aid=b.bid 
>  {noformat}
>  h4. (/) Expected result
>  {noformat}
>     3,44
>  {noformat}
>  h4. (!) Incorrect actual result
>  {noformat}
>     1,66 
>  {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message