phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4150) Adding a policy filter to whitelist the properties that allow to be passed to Phoenix
Date Thu, 07 Sep 2017 18:54:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157438#comment-16157438
] 

Thomas D'Silva commented on PHOENIX-4150:
-----------------------------------------

You might be able to unit test your provider by adding the configuration file to src/test/resources/META-INF/services/
. Your provider would be used for all unit tests, so in order to test it you could test throwing
an exception for a fake property (which would not be used in other tests).

> Adding a policy filter to whitelist the properties that allow to be passed to Phoenix
> -------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4150
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4150
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ethan Wang
>            Assignee: Ethan Wang
>            Priority: Critical
>         Attachments: PHOENIX-4150-v1.patch, PHOENIX-4150-v2.patch
>
>
> Adding a policy filter to whitelist the properties that allow to be passed to Phoenix.
> Feature proposal:
> When user getting phoenix connection via
> Connection conn = DriverManager.getConnection(connectionString, properties);
> A properties whitelist policy will essentially check each properties that passed in (likely
happen at PhoenixDriver.java), so that the un-allowed property will result in an exception
been thrown.
> Similar to HBaseFactoryProvider, proposing have a interface for whitelist policy and
a default impl that will by default allow all properties. User can override the impl for this
interface to start using whitelist feature
> [~jamestaylor]   [~alexaraujo]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message