phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4152) Don't swallow or wrap exception in BaseQueryIT constructor
Date Sat, 02 Sep 2017 08:30:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151445#comment-16151445
] 

Hadoop QA commented on PHOENIX-4152:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12885063/PHOENIX-4152_v3.patch
  against master branch at commit 9fb318bd8f03911bc7cb333a0ec974a685156fb7.
  ATTACHMENT ID: 12885063

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    public AggregateQueryIT(String indexDDL, boolean mutable, boolean columnEncoded)
throws Exception {
+    public CaseStatementIT(String indexDDL, boolean mutable, boolean columnEncoded) throws
Exception {
+    public CastAndCoerceIT(String indexDDL, boolean mutable, boolean columnEncoded) throws
Exception {
+    public ClientTimeArithmeticQueryIT(String indexDDL, boolean mutable, boolean columnEncoded)
throws Exception {
+    public MutableQueryIT(String indexDDL, boolean mutable, boolean columnEncoded) throws
Exception {
+    public PointInTimeQueryIT(String indexDDL, boolean mutable, boolean columnEncoded) throws
Exception {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1358//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1358//console

This message is automatically generated.

> Don't swallow or wrap exception in BaseQueryIT constructor
> ----------------------------------------------------------
>
>                 Key: PHOENIX-4152
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4152
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4152.patch, PHOENIX-4152_v2.patch, PHOENIX-4152_v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message