phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4156) Fix flapping MutableIndexFailureIT
Date Mon, 04 Sep 2017 16:03:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152753#comment-16152753
] 

James Taylor commented on PHOENIX-4156:
---------------------------------------

Thanks, [~samarthjain]. Code doesn't agree with comment here. When would the table level property
matter if the global config has the rebuilder turned off?
{code}
PhoenixIndexFailurePolicy.java
@@ -87,18 +87,17 @@ public class PhoenixIndexFailurePolicy extends DelegateIndexFailurePolicy
{
     public void setup(Stoppable parent, RegionCoprocessorEnvironment env) {
         super.setup(parent, env);
         this.env = env;
-        rebuildIndexOnFailure = env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB,
-                QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD);
         HTableDescriptor htd = env.getRegion().getTableDesc();
         // If rebuild index is turned off globally, no need to check the table because the
background thread
         // won't be running in this case
{code}

> Fix flapping MutableIndexFailureIT
> ----------------------------------
>
>                 Key: PHOENIX-4156
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4156
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message