phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4162) Disallow transition from DISABLE to INACTIVE when INDEX_DISABLE_TIMESTAMP is zero
Date Wed, 06 Sep 2017 04:11:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154781#comment-16154781
] 

Hadoop QA commented on PHOENIX-4162:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12885500/PHOENIX-4162.patch
  against master branch at commit a1c75a9ec31eb646d7f4e0eb2363e8dc6d465103.
  ATTACHMENT ID: 12885500

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            conn.createStatement().execute("CREATE TABLE " + fullTableName + "(k INTEGER
PRIMARY KEY, v1 INTEGER, v2 INTEGER) COLUMN_ENCODED_BYTES = 0, STORE_NULLS=true, GUIDE_POSTS_WIDTH=1000");
+            conn.createStatement().execute("CREATE INDEX " + indexName1 + " ON " + fullTableName
+ " (v1) INCLUDE (v2)");
+            HTableInterface metaTable = conn.unwrap(PhoenixConnection.class).getQueryServices().getTable(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES);
+            MutationCode code = IndexUtil.updateIndexState(fullIndexName1, 0L, metaTable,
PIndexState.DISABLE).getMutationCode();
+            code = IndexUtil.updateIndexState(fullIndexName1, ts, metaTable, PIndexState.INACTIVE).getMutationCode();
+                if ((currentDisableTimeStamp != null && currentDisableTimeStamp.getValueLength()
> 0)) {
+                    curTimeStampVal = (Long) PLong.INSTANCE.toObject(currentDisableTimeStamp.getValueArray(),
+                        long newDisableTimeStamp = (Long) PLong.INSTANCE.toObject(newDisableTimeStampCell.getValueArray(),
+                                newDisableTimeStampCell.getValueOffset(), newDisableTimeStampCell.getValueLength());
+                        // We never set the INDEX_DISABLE_TIMESTAMP to a positive value when
we're setting the state to ACTIVE.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NotQueryIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1379//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1379//console

This message is automatically generated.

> Disallow transition from DISABLE to INACTIVE when INDEX_DISABLE_TIMESTAMP is zero
> ---------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4162
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4162
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4162.patch
>
>
> When the index state is DISABLE and the INDEX_DISABLE_TIMESTAMP is zero, we should not
allow the index to be set back to an INACTIVE state. The only allowed transition is back to
a building state as the index needs to be rebuild from scratch at this point.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message