From dev-return-45243-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org Wed Sep 27 00:23:08 2017 Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C63C104C3 for ; Wed, 27 Sep 2017 00:23:08 +0000 (UTC) Received: (qmail 66612 invoked by uid 500); 27 Sep 2017 00:23:08 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 66555 invoked by uid 500); 27 Sep 2017 00:23:08 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 66544 invoked by uid 99); 27 Sep 2017 00:23:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 00:23:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DEDBF182353 for ; Wed, 27 Sep 2017 00:23:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id CugPkGQNJQkh for ; Wed, 27 Sep 2017 00:23:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6859660D9C for ; Wed, 27 Sep 2017 00:23:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A6C54E0059 for ; Wed, 27 Sep 2017 00:23:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 17ADB24272 for ; Wed, 27 Sep 2017 00:23:04 +0000 (UTC) Date: Wed, 27 Sep 2017 00:23:04 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181779#comment-16181779 ] Hadoop QA commented on PHOENIX-4138: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12889159/PHOENIX-4138.v2.patch against master branch at commit 5d9572736a991f19121477a0822d4b8bf26b4c69. ATTACHMENT ID: 12889159 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + assertFalse(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX, parentTable, configuration)); + assertTrue(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX, parentTable, configuration)); + conn1.createStatement().execute("CREATE INDEX " + indexTableNameOne + " ON " + tableName + "(COL1) INCLUDE (COL2,COL3,COL4)"); + // here we ensure we get a too many indexes error since we are only allowed a max of one index. + conn1.createStatement().execute("CREATE INDEX " + indexTableNameTwo + " ON " + tableName + "(COL2) INCLUDE (COL1,COL3,COL4)"); + assertEquals("ERROR 1047 (43A04): Too many indexes have already been created on the physical table. tableName=T000001", e.getMessage()); + static boolean execeededIndexQuota(PTableType tableType, PTable parentTable, Configuration configuration) { {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertValuesIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1484//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1484//console This message is automatically generated. > Create a hard limit on number of indexes per table > -------------------------------------------------- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug > Reporter: Rahul Shrivastava > Assignee: churro morales > Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch, PHOENIX-4138.v2.patch, PHOENIX-4138_v3.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of indexes per table. There is a SQL Exception https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 , but it gets triggered on the server side (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) . > We need a client side limit that can be configured via Phoenix config parameter. Something like if user create more than lets say 30 indexes per table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)