phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3757) System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
Date Wed, 25 Oct 2017 16:04:03 GMT


ASF GitHub Bot commented on PHOENIX-3757:

Github user joshelser commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/
    @@ -2526,8 +2541,14 @@ private void createOtherSystemTables(PhoenixConnection metaConnection)
throws SQ
             try {
             } catch (TableAlreadyExistsException ignore) {}
    +        // We catch TableExistsException in createSysMutexTable() and ignore it. Hence
we will also ignore IOException here.
    +        // SYSTEM.MUTEX table should not be exposed to user. Hence it is directly created
and used via HBase API.
    +        // Using 'CREATE TABLE' statement will add entries to SYSTEM.CATALOG table, which
should not happen.
    +        try {
    +            createSysMutexTable(hBaseAdmin, ConnectionQueryServicesImpl.this.getProps());
    +        } catch (IOException ignore) {}
    --- End diff --
    What about the case where the table creation failed for a legitimate system reason (something
an admin needs to correct)? We should at least have some warning to the user that we failed
to created the table, right?

> System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
> ------------------------------------------------------------------------------------------
>                 Key: PHOENIX-3757
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Karan Mehta
>            Priority: Critical
>              Labels: namespaces
>             Fix For: 4.13.0
>         Attachments: PHOENIX-3757.001.patch, PHOENIX-3757.002.patch, PHOENIX-3757.003.patch
> Noticed this issue while writing a test for PHOENIX-3756:
> The SYSTEM.MUTEX table is always created in the default namespace, even when {{phoenix.schema.isNamespaceMappingEnabled=true}}.
At a glance, it looks like the logic for the other system tables isn't applied to the mutex

This message was sent by Atlassian JIRA

View raw message