phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Skrabak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4139) select distinct with identical aggregations return weird values
Date Fri, 01 Dec 2017 15:30:03 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274513#comment-16274513
] 

Csaba Skrabak commented on PHOENIX-4139:
----------------------------------------

While [^PHOENIX-4139_v2.patch] will fix the test, I'm still unhappy because the "accessor"
of the second TRIM(NAM) is the same as that of the first one. First it will contain the correct
index but the second time it contains that of the first expression. What is the accessor for
if we don't care what exactly it accesses? The information it holds can be derived, actually
it IS derived in the wrapGroupByExpression method from the Expression object. The fact that
the index may be right or wrong in it may lead to other issues.

> select distinct with identical aggregations return weird values 
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-4139
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4139
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.12.0
>         Environment: minicluster
>            Reporter: Csaba Skrabak
>            Assignee: Csaba Skrabak
>            Priority: Minor
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4139.patch, PHOENIX-4139_v2.patch
>
>
> From sme-hbase hipchat room:
> Pulkit Bhardwaj·10:31
> i'm seeing a weird issue with phoenix, appreciate some thoughts
> Created a simple table in phoenix
> {noformat}
> 0: jdbc:phoenix:> create table test_select(nam VARCHAR(20), address VARCHAR(20), id
BIGINT
> . . . . . . . . > constraint my_pk primary key (id));
> 0: jdbc:phoenix:> upsert into test_select (nam, address,id) values('pulkit','badaun',1);
> 0: jdbc:phoenix:> select * from test_select;
> +---------+----------+-----+
> |   NAM   | ADDRESS  | ID  |
> +---------+----------+-----+
> | pulkit  | badaun   | 1   |
> +---------+----------+-----+
> 0: jdbc:phoenix:> select distinct 'harshit' as "test_column", nam from test_select;
> +--------------+---------+
> | test_column  |   NAM   |
> +--------------+---------+
> | harshit      | pulkit  |
> +--------------+---------+
> 0: jdbc:phoenix:> select distinct 'harshit' as "test_column", trim(nam), trim(nam)
from test_select;
> +--------------+----------------+----------------+
> | test_column  |   TRIM(NAM)    |   TRIM(NAM)    |
> +--------------+----------------+----------------+
> | harshit      | pulkitpulkit  | pulkitpulkit  |
> +--------------+----------------+----------------+
> {noformat}
> When I apply a trim on the nam column and use it multiple times, the output has the cell
data duplicated!
> {noformat}
> 0: jdbc:phoenix:> select distinct 'harshit' as "test_column", trim(nam), trim(nam),
trim(nam) from test_select;
> +--------------+-----------------------+-----------------------+-----------------------+
> | test_column  |       TRIM(NAM)       |      
TRIM(NAM)       |       TRIM(NAM)       |
> +--------------+-----------------------+-----------------------+-----------------------+
> | harshit      | pulkitpulkitpulkit  | pulkitpulkitpulkit  | pulkitpulkitpulkit  |
> +--------------+-----------------------+-----------------------+-----------------------+
> {noformat}
> Wondering if someone has seen this before??
> One thing to note is, if I remove the —— distinct 'harshit' as "test_column" ——  The
issue is not seen
> {noformat}
> 0: jdbc:phoenix:> select trim(nam), trim(nam), trim(nam) from test_select;
> +------------+------------+------------+
> | TRIM(NAM)  | TRIM(NAM)  | TRIM(NAM)  |
> +------------+------------+------------+
> | pulkit     | pulkit     | pulkit     |
> +------------+------------+------------+
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message