phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4514) A incorrect key object is used in SequenceManager#validateSequences
Date Wed, 10 Jan 2018 05:44:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319723#comment-16319723
] 

Chia-Ping Tsai commented on PHOENIX-4514:
-----------------------------------------

bq. Would you be up for providing a patch?
sure

bq. Also, the fixVersion field is set after the fix is committed to indicate the release in
which the fix will appear.
Thanks for the reminder.

> A incorrect key object is used in SequenceManager#validateSequences
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-4514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4514
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>
> nextSequences.get( i ) -> nextSequences.get( i ).getSequenceKey()
> {code:title=SequenceManager.java}
>         for (int i = 0; i < nextSequences.size(); i++) {
>             sequencePosition[i] = sequenceMap.get(nextSequences.get(i)).getIndex();
>         }
> {code}
> It won't cause bug since the impl of SequenceAllocation#hashCode is equal with SequenceKey#hashCode.
However, it still a potential bug so a fix is necessary I believe.
> {code:title=SequenceAllocation.java}
>     @Override
>     public int hashCode() {
>         return sequenceKey.hashCode();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message