phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4523) phoenix.schema.isNamespaceMappingEnabled problem
Date Fri, 12 Jan 2018 07:11:00 GMT


Hadoop QA commented on PHOENIX-4523:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against 4.x-HBase-0.98 branch at commit 27d6582827b9306e66d3bfd430c6186ac165fb08.
  ATTACHMENT ID: 12905805

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +    void createSysMutexTableIfNotExists(HBaseAdmin admin, ReadOnlyProps props) throws
IOException, SQLException {
+            // Check for both SYSTEM.MUTEX and SYSTEM:MUTEX and donot proceed if either of
them exists
+            if(admin.tableExists(PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME) || admin.tableExists(TableName.valueOf(
+                    PhoenixDatabaseMetaData.SYSTEM_SCHEMA_NAME,PhoenixDatabaseMetaData.SYSTEM_MUTEX_TABLE_NAME)))
+            if (!Iterables.isEmpty(Iterables.filter(Throwables.getCausalChain(e), AccessDeniedException.class))
+                    !Iterables.isEmpty(Iterables.filter(Throwables.getCausalChain(e), TableExistsException.class)))
+      "Destination Table %s already exists. No migration
needed.", destTableName));
+        doNothing().when(cqs).createSysMutexTableIfNotExists(any(HBaseAdmin.class), any(ReadOnlyProps.class));
+        when(cqs.getSystemTableNamesInDefaultNamespace(any(HBaseAdmin.class))).thenReturn(Collections.<TableName>

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> phoenix.schema.isNamespaceMappingEnabled problem
> ------------------------------------------------
>                 Key: PHOENIX-4523
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.1
>            Reporter: Flavio Pompermaier
>            Assignee: Karan Mehta
>             Fix For: 5.0.0, 4.14.0, 4.13.2-cdh5.11.2
>         Attachments: PHOENIX-4523.001.4.x-HBase-0.98.patch, PHOENIX-4523.001.patch
> I'm using Phoenix 4.13 for CDH 5.11.2 parcel and enabling schemas made my code unusable.
> I think that this is not a bug of the CDH release, but of all 4.13.x releases.
> I have many parallel Phoenix connections and I always get the following exception:
> {code:java}
> Caused by: java.sql.SQLException: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.hbase.TableExistsException):
> 	at org.apache.phoenix.query.ConnectionQueryServicesImpl$
> 	at org.apache.phoenix.query.ConnectionQueryServicesImpl$
> 	at
> 	at org.apache.phoenix.query.ConnectionQueryServicesImpl.init(
> 	at org.apache.phoenix.jdbc.PhoenixDriver.getConnectionQueryServices(
> 	at org.apache.phoenix.jdbc.PhoenixEmbeddedDriver.createConnection(
> 	at org.apache.phoenix.jdbc.PhoenixDriver.connect(
> 	at java.sql.DriverManager.getConnection(
> 	at java.sql.DriverManager.getConnection(
> {code}
> This is caused by the fact that all the times the SYSTEM tables are recreated, and this
cannot be done simultaneously.
> Trying to debug the issue I found that in ConnectionQueryServicesImpl.createSysMutexTable()
the call to getSystemTableNames() always return an empty array and the SYSTEM:MUTEX  table
is always recreated.
> This because getSystemTableNames() doesn't consider the case when system tables have
namespace enabled. Right now that method tries to get all tables starting with *SYSTEM.\**,
while it should try to get the list of *SYSTEM:\** tables..
> I hope this could get fixed very soon,
> Flavio

This message was sent by Atlassian JIRA

View raw message