phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...
Date Tue, 03 Apr 2018 19:35:56 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/295#discussion_r178933517
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
    @@ -1039,10 +1065,20 @@ private HTableDescriptor ensureTableCreated(byte[] physicalTableName,
PTableType
                     }
                 }
     
    +            if (isMetaTable && SchemaUtil.isNamespaceMappingEnabled(PTableType.SYSTEM,
    --- End diff --
    
    The ensureSystemTablesMigratedToSystemNamespace has race conditions in the case of multiple
clients executing it at the same time. We should treat this as an upgrade step and do it while
we have the SYSTEM.MUTEX lock (which ensures only a single client will be executing upgrade
code).


---

Mime
View raw message