phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Istvan Toth <st...@apache.org>
Subject Please don't use unshaded Guava classes in Phoenix master
Date Thu, 24 Sep 2020 03:54:14 GMT
Hi!

We have recently switched to shaded Guava from phoenix-thirdparty in master.

Using unshaded Guava will break maven verify (and cause dependency problems
down the line), so please take care not to commit patches that use unshaded
Guava classes.

Yetus does flag these patches with -1.

I know that the tests are in bad shape, and the IT results are kind of
useless in the PreCommit check right now, but Yetus flags this problem as
an *mvninstall* error, which should be taken seriously:

   Patch Compile Tests
-1 mvninstall 1m 14s root in the patch failed.

you'll see the following line in the linked mvn install log:

[WARNING] Used undeclared dependencies found:
[WARNING]    com.google.guava:guava:jar:11.0.2:compile


regards
Istvan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message