phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (Jira)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true
Date Fri, 11 Sep 2020 22:07:00 GMT
Chinmay Kulkarni created PHOENIX-6124:
-----------------------------------------

             Summary: Block adding/dropping a column on a parent view for clients <4.15
and for clients that have phoenix.allow.system.catalog.rollback=true
                 Key: PHOENIX-6124
                 URL: https://issues.apache.org/jira/browse/PHOENIX-6124
             Project: Phoenix
          Issue Type: Bug
    Affects Versions: 4.15.0, 5.0.0
            Reporter: Chinmay Kulkarni
             Fix For: 5.1.0, 4.16.0


For pre-4.15 clients, we have to block adding/dropping a column to a table if it has child
views since we can’t do any checkAndPut distributed locking (see [this|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2595-L2616]).


However, this is only prevented if the parent is a table and not if the parent is a view.
We should extend [the condition|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2591]
to also cover views since conflicting mutations on its children can also lead to inconsistencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message