phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix-omid] stoty commented on a change in pull request #82: OMID-191 Fix missing executable permission because of MASSEMBLY-941
Date Wed, 02 Dec 2020 05:04:51 GMT

stoty commented on a change in pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82#discussion_r533897088



##########
File path: pom.xml
##########
@@ -250,6 +251,7 @@
 
                 <plugin>
                     <artifactId>maven-assembly-plugin</artifactId>
+                    <version>${maven-assembly-plugin-version}</version>

Review comment:
       Specifying the version in the pluginManagement section of the top-level pom will set
it for every child.
   There's no need to specify the version elsewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message