pirk-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ellisonanne <...@git.apache.org>
Subject [GitHub] incubator-pirk pull request #108: WIP: Submodule Refactor Phase 1
Date Mon, 17 Oct 2016 00:22:40 GMT
Github user ellisonanne commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/108#discussion_r83564697
  
    --- Diff: pirk-core/src/main/java/org/apache/pirk/test/distributed/DistributedTestCLI.java
---
    @@ -18,12 +18,7 @@
      */
     package org.apache.pirk.test.distributed;
     
    -import org.apache.commons.cli.CommandLine;
    -import org.apache.commons.cli.CommandLineParser;
    -import org.apache.commons.cli.GnuParser;
    -import org.apache.commons.cli.HelpFormatter;
    -import org.apache.commons.cli.Option;
    -import org.apache.commons.cli.Options;
    +import org.apache.commons.cli.*;
    --- End diff --
    
    We need to take out the * imports - prob just inadvertently added in via your IDE - this
is throughout the PR 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message