pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Brind <bri...@brindy.org.uk>
Subject Re: Collections
Date Tue, 02 Jun 2009 23:19:53 GMT
Had a very quick look at this work just now.  I ran the test using a
coverage tool (Eclemma - very useful and lightweight) and you're only
covering about 50% of the ArrayList with your test.  Since these class are
'pivotal' (pun intended) I think it's pretty vital that they are tested with
100% coverage via a unit test as this will save a lot of tears, hair pulling
and manual testing later.

I will try and find some time to improve the coverage when I have more time
after Thursday (my wife's degree show).

This is the tool I was referring to:


2009/5/31 Greg Brown <gkbrown@mac.com>

> Hi all,
> I just checked in an update to the collection classes that provides
> Pivot-native implementations of ArrayList and LinkedList (i.e. they don't
> simply wrap the corresponding java.util collection). This is something we
> had planned to do for a while but didn't have time for until now. We'll be
> implementing HashMap and HashSet natively as well.
> This change will not be included in version 1.2, but will be part of 1.3.
> Note that both ArrayList and LinkedList require further testing - since
> ArrayList is used extensively throughout the codebase, you may see some
> issues as a result of this update. I've written up some unit tests and smoke
> tested most of our demos and tutorials; however, if you do see an issue,
> please let me know by filing a JIRA ticket.
> Thanks,
> Greg

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message