pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Brown (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (PIVOT-166) Decorators are given incorrect clip rect
Date Wed, 08 Jul 2009 23:03:14 GMT

     [ https://issues.apache.org/jira/browse/PIVOT-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Greg Brown resolved PIVOT-166.
------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: 1.3)

This is by design. Decorators are always clipped to the parent's bounds, since many decorators
need to draw outside the component's bounds (e.g. drop shadows). 

Since decorators use a chained prepare/update model, we can't assume that it is OK to clip
to the decorated bounds in the prepare() phase, since that clip rect may not be valid for
subsequent decorator update()s, and almost certainly won't be valid for the component itself,
which paints into a copy of the final prepared graphics but must be clipped to the intersection
of its own bounds and the current clip (not the intersections of all preceding decorator prepare()
calls).

As a result, the only assumption that decorators can make is that drawing will be clipped
to the parent's bounds.


> Decorators are given incorrect clip rect
> ----------------------------------------
>
>                 Key: PIVOT-166
>                 URL: https://issues.apache.org/jira/browse/PIVOT-166
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk-effects
>            Reporter: Todd Volkert
>            Assignee: Todd Volkert
>
> Run the WatermarkDecoratorTest to see this behavior.  WatermarkDecorator reports the
component's bounds in getBounds(), it uses an identity transform, and it doesn't alter the
clip rect of the graphics, yet the watermark is being painted outside the bounds of the decorated
component (in the case of the test, the decorated component is the CardPane that lives in
the TablePane's row beklow the line).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message