pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Brown (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIVOT-471) Make TableView.getSelectedRanges() iterable
Date Tue, 20 Apr 2010 12:27:51 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858851#action_12858851
] 

Greg Brown commented on PIVOT-471:
----------------------------------

FYI, I moved the ListSelection patch to PIVOT-469 since it is more closely related to that
change.


> Make TableView.getSelectedRanges() iterable
> -------------------------------------------
>
>                 Key: PIVOT-471
>                 URL: https://issues.apache.org/jira/browse/PIVOT-471
>             Project: Pivot
>          Issue Type: Wish
>          Components: wtk
>            Reporter: Dirk Moebius
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: ListSelection_toString.patch.txt
>
>
> Iterating over the results of TableView.getSelectedRanges() is cumbersome because it
returns a Sequence<Span> which is not iterable using a for-each loop. Instead it should
return a List<Span>, which is iterable. Javadoc should state that the returned List
is immutable.
> Likewise for:
> - ListView.getSelectedRanges()
> - TreeView.getSelectedPaths()
> - FileBrowser.getSelectedFiles()
> - FileBrowserSheet.getSelectedFiles()
> JavaDoc of TableView.getSelectedRows() should clearly state that this is a convenience
method only, and that it allocates a result array on each invocation. Likewise for ListView.getSelectedItems().
> See http://mail-archives.apache.org/mod_mbox/pivot-user/201004.mbox/%3c20100419141642.10608d0zs3wp5cx4@www.premium-webmail.de%3e
for motivation of this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message