pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Brown (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIVOT-458) ListButton: show popup only on triangle click
Date Thu, 15 Apr 2010 19:08:49 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857489#action_12857489

Greg Brown commented on PIVOT-458:

FYI, I applied the patch and it looks good overall. However, I now think I see why "split"
may not have made sense to you. When this style is set to true, I would expect that clicking
on the trigger would only show the trigger pressed state, and vice versa for the content area
(the non-trigger section) of the button. However, as currently implemented, the entire button
appears pressed regardless of which side is clicked.

Would you be willing to take a stab at implementing this behavior? I think it will involve
maintaining a value representing which part of the button is pressed and painting the proper
pressed state in paint(). A simple boolean "triggerPressed" flag may suffice, since TerraListButtonSkin
already inherits a "pressed" member from the base class.

> ListButton: show popup only on triangle click
> ---------------------------------------------
>                 Key: PIVOT-458
>                 URL: https://issues.apache.org/jira/browse/PIVOT-458
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Dirk Moebius
>            Priority: Minor
>         Attachments: listbutton-popup.patch, menubutton-popup.patch
> I found this to be a requirement in my application: if the user clicks the label part
of a LinkButton, the button should fire immediately without showing the popup, thus invoking
the action with the currently selected entry. If the user clicks the triangle part, the popup
should be shown.
> I patched LinkButton to add a new boolean property called "showPopupOnTriggerClickOnly"
to TerraListButtonSkin (I couldn't think of a better name, sorry). If set to true, the ListButton
popup will only show up if the user clicks the triangle, but not if the user clicks the rest
of the button. However, ButtonPressListeners fire as usual, if the user clicks any part of
the button. If the property is false, the behavior is as it was before. The default value
of the property is false.
> I tested the patch in my application and ComponentExplorer and it works good.
> It would be nice if you integrate the patch. Otherwise I'd still have the option to write
a custom skin, but I think this patch could be interesting to other developers as well.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message