pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dirk Moebius (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIVOT-458) ListButton: show popup only on triangle click
Date Tue, 20 Apr 2010 15:03:53 GMT

     [ https://issues.apache.org/jira/browse/PIVOT-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dirk Moebius updated PIVOT-458:
-------------------------------

    Attachment: listbutton-popup-splitpaint.patch

> I just added you as a Contributor, so you should be able to assign the issue to yourself
now.

Thanks.

> I just committed a modified version of this patch (I renamed the style to "split"). Looking
at it again, I think the UE is OK. You are welcome to implement the split paint behavior if
you like, or we can revisit it another time. Up to you.

Well, I had already begun with it, but I'm not happy with the patch:

- pressing SPACE in split mode doesn't show the popup but fires the ButtonPressed event. There's
no way to show the popup if split mode is on, because I didn't implement the SHIFT-DOWN function.
- I had to overwrite too many methods from ListButtonSkin to maintain the 'triggerPressed'
boolean state (enableChanged(), focusChanged(), mouseOut(), mouseDown(),  keyPressed(), keyReleased())

FWIW, here's my modification I had done so far, just for reference. Please do not include
it.

> ListButton: show popup only on triangle click
> ---------------------------------------------
>
>                 Key: PIVOT-458
>                 URL: https://issues.apache.org/jira/browse/PIVOT-458
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Dirk Moebius
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: listbutton-popup-splitpaint.patch, listbutton-popup.patch, menubutton-popup.patch,
office-listbutton-hovered.png, office-listbutton-normal.png, office-listbutton-pressed.png,
office-listbutton-triggerclicked.png
>
>
> I found this to be a requirement in my application: if the user clicks the label part
of a LinkButton, the button should fire immediately without showing the popup, thus invoking
the action with the currently selected entry. If the user clicks the triangle part, the popup
should be shown.
> I patched LinkButton to add a new boolean property called "showPopupOnTriggerClickOnly"
to TerraListButtonSkin (I couldn't think of a better name, sorry). If set to true, the ListButton
popup will only show up if the user clicks the triangle, but not if the user clicks the rest
of the button. However, ButtonPressListeners fire as usual, if the user clicks any part of
the button. If the property is false, the behavior is as it was before. The default value
of the property is false.
> I tested the patch in my application and ComponentExplorer and it works good.
> It would be nice if you integrate the patch. Otherwise I'd still have the option to write
a custom skin, but I think this patch could be interesting to other developers as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message