pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dirk Moebius (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIVOT-35) Replace Dispatcher with ExecutorService
Date Mon, 19 Apr 2010 07:25:49 GMT

     [ https://issues.apache.org/jira/browse/PIVOT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Dirk Moebius updated PIVOT-35:

    Attachment: change_task_subclass_constructors.patch

Hi Greg, your change looks very good. I thought of getting rid of Dispatcher, too, but then
I thought that this change might be to big.

A minor nitpick: I'd change the Task subclasses such as LoadTask or Query to use the no-arg
super constructor instead of using the constructor with ExecutorService parameter, so that
the subclasses don't need to be aware of DEFAULT_EXECUTOR_SERVICE at all. My attached patch
changes this.

> Replace Dispatcher with ExecutorService
> ---------------------------------------
>                 Key: PIVOT-35
>                 URL: https://issues.apache.org/jira/browse/PIVOT-35
>             Project: Pivot
>          Issue Type: Improvement
>          Components: core-util
>            Reporter: Greg Brown
>            Assignee: Greg Brown
>             Fix For: 1.5
>         Attachments: change_task_subclass_constructors.patch, dispatcher.patch, dispatcher.patch

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message