pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Brown <gk_br...@verizon.net>
Subject Re: TableView multi-selection broken in trunk?
Date Wed, 18 May 2011 21:24:06 GMT
>> I just reverted the changes that broke multi-select.
> You could have wait a little more, I have the fix for both ...

As I mentioned in the JIRA issue, it is preferable to maintain stability and reverting the
change was the easiest way to do that.

>> Sandro, please make sure that you test more thoroughly before committing any additional
changes. Thanks.
> Yes, of course, but the problem is that I've seen it only when I
> created some Tests for it (part of the commit I'm doing now) ... maybe
> even other developers could make some tests sometimes ...

Of course. But you changed the mouse handling code in three core classes and should have tested
more thoroughly before committing.

View raw message