pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sandro Martini <sandro.mart...@gmail.com>
Subject Re: FindBugs Analysis
Date Fri, 17 Jun 2011 14:38:54 GMT
Uh ... you know that I have little memory ... but I'll try (could be others,
sorry).

Already discussed (at the top of previous list):
charts/src/org/apache/pivot/charts/content/ValueSeries.java:1
org.apache.pivot.charts.content.ValueSeries doesn't override
org.apache.pivot.collections.ArrayList.equals(Object)
tutorials/src/org/apache/pivot/tutorials/webqueries/Expenses.java:45 Write
to static field org.apache.pivot.tutorials.webqueries.Expenses.instance from
instance method new org.apache.pivot.tutorials.webqueries.Expenses()

demos/src/org/apache/pivot/demos/roweditor/AmountBindMapping.java:36
org.apache.pivot.demos.roweditor.AmountBindMapping.valueOf(String) invokes
inefficient new String(String) constructor
demos/src/org/apache/pivot/demos/rss/RSSItemRenderer.java:82 Method
org.apache.pivot.demos.rss.RSSItemRenderer.render(Object, int, ListView,
boolean, boolean, boolean, boolean) concatenates strings using + in a loop

And these (at the end of previous list):
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraActivityIndicatorSkin.java:88
Dead store to increment
  -- maybe a static constant here could solve ...

And last:
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAlertSkin.java:108
Unchecked/unconfirmed cast from org.apache.pivot.wtk.Window to
org.apache.pivot.wtk.Alert
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java:307
Unchecked/unconfirmed cast from org.apache.pivot.wtk.Window to
org.apache.pivot.wtk.SuggestionPopup
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSheetSkin.java:273
Unchecked/unconfirmed cast from org.apache.pivot.wtk.Sheet to
org.apache.pivot.wtk.FileBrowserSheet
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPromptSkin.java:107
Unchecked/unconfirmed cast from org.apache.pivot.wtk.Window to
org.apache.pivot.wtk.Prompt
wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java:225
Unchecked/unconfirmed cast from org.apache.pivot.wtk.Window to
org.apache.pivot.wtk.MenuPopup

but probably for these could be better to change the signature of generics
here, like <... extends ...> or something like this, to have compile-time
checks ... maybe in the 2.1 release.
What do you think ?



All others should be inspected ...

Bye


--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/FindBugs-Analysis-tp3076403p3076491.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.

Mime
View raw message