pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-834) Form.getSection(Component) to return the section for nested components
Date Tue, 23 Oct 2012 17:49:13 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482513#comment-13482513
] 

Roger Whitcomb commented on PIVOT-834:
--------------------------------------

In looking into this change, there are some subtle implications to changing the existing method:
1) TerraFormSkin uses Form.getSection() in conjunction with section.indexOf() in the "labelChanged"
method.  This probably would break badly with the proposed change, and the follow-on changes
to "getIndex" and etc. would quickly get to be very confusing.
2) As someone noted this is easy enough to implement in an application by following the parent
chain.

So, I would propose adding another method: "Form.getEnclosingSection(Component)" that would
do what is requested for when it is needed, but leave the existing method alone.
                
> Form.getSection(Component) to return the section for nested components
> ----------------------------------------------------------------------
>
>                 Key: PIVOT-834
>                 URL: https://issues.apache.org/jira/browse/PIVOT-834
>             Project: Pivot
>          Issue Type: New Feature
>          Components: wtk
>    Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3
>            Reporter: David Keen
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.0.4
>
>
> Form.getSection returns the Form.Section of the given component.  However, it currently
only works for top-level components and returns null for components nested inside other components.
> This request is for the method to return the correct form section for all components
of a form, regardless of whether they are nested or not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message