pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandro Martini (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-558) BeanAdapter should have a putAll method to allow multiple property set in one method call...especially useful when setting properties from a JSON string
Date Wed, 17 Oct 2012 09:28:03 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477731#comment-13477731
] 

Sandro Martini commented on PIVOT-558:
--------------------------------------

Hi Steven, thank for the feedback ... my comments here:
first, as you I think this would be a good addition.

> At the very least, the putAll method without the ignoreErrors flag should go into the
Map interface.
this is the reason we move its implementation in 2.1
> I don't see a problem with adding the one with ignoreErrors on BeanAdapter (or in a separate
utility class) 
yes, the additional method (but without changing the api of Map in 2.0.x) could be put there,
but don't remember it this would be enough now (in 2.0.x) to make it work, I have to look
at the code but now I'm really busy. If this is possible now I'm not against do something
already in 2.0.x ... maybe splitting this issue in two, with the new one for 2.0.3 .

For comments, suggestions and maybe patch, be free to post here.
Thanks again for now.

                
> BeanAdapter should have a putAll method to allow multiple property set in one method
call...especially useful when setting properties from a JSON string
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-558
>                 URL: https://issues.apache.org/jira/browse/PIVOT-558
>             Project: Pivot
>          Issue Type: Improvement
>          Components: core-beans
>            Reporter: Appddevvv
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.1
>
>
> API:
> public void putAll(Map<String, ?> values)
> public boolean putAll(Map<String, ?> values, boolean ignoreErrors)
> where ignore errors indicates that any errors/exceptions thrown should be caught. If
any are thrown or errors occur, true is returned, otherwise false.
> I'll submit a patch if you accept this improvement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message