pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandro Martini (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-916) Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
Date Tue, 01 Oct 2013 08:35:24 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782723#comment-13782723
] 

Sandro Martini commented on PIVOT-916:
--------------------------------------

Just committed the patch from Roger.
If no objections, in a few days I'll mark this as resolved ... thanks to all for the help.

Now I'll check if ScriptApplication need some changes.
Finally I'll do the merge into trunk.


> Replace DesktopApplicationContext.displayException calls with ApplicationContext.handleUncaughtException
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-916
>                 URL: https://issues.apache.org/jira/browse/PIVOT-916
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Karel Hübl
>            Assignee: Sandro Martini
>             Fix For: 2.0.4
>
>         Attachments: app_exception.patch, ScriptApplication.java.patch, trunk_wtk.patch,
wtk_test.zip
>
>
> There should be consistent way to handle uncaught exceptions in Pivot applications. 
> However uncaught exceptions thrown in DesktopApplicationContext  class (for example in
application.startup ) are handled using private static method displayException, which displays
dialog and its logic cannot be overriden.
> May be ApplicationContext.handleUncaughtException could be made protected and calls to
DesktopApplicationContext.displayException could be replaced by  ApplicationContext.handleUncaughtException.
And possibly Application.Adapter could implement UncaughtExceptionHandler - so current DesktopApplicationContext.displayException
logic could be moved to new Application.Adapter.uncaughtExceptionThrown method.
> This should enable to override uncaught exception handling globally in pivot applications.
> Motivation:
> We deploy Pivot app using Java Web Start. Users have by default disabled Java Console
(and they are not familiar with it). We want to display custom dialog to handle uncaught exceptions
displaying full stack trace and with possiblity to report exception to help desk.
> I think, in current implementation it is not possible to override handling of uncaught
exceptions thrown during application init and other specific situations.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message