pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (PIVOT-924) Standard handling of exceptions in BXMLSerializer
Date Tue, 29 Oct 2013 18:40:27 GMT

     [ https://issues.apache.org/jira/browse/PIVOT-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Roger Whitcomb resolved PIVOT-924.
----------------------------------

    Resolution: Fixed

Applied (modified) patch to both trunk and 2.0.x branch.

Closing this as resolved, but Karel, feel free to reopen if you have issues.

Thank you for the patch.

> Standard handling of exceptions in BXMLSerializer
> -------------------------------------------------
>
>                 Key: PIVOT-924
>                 URL: https://issues.apache.org/jira/browse/PIVOT-924
>             Project: Pivot
>          Issue Type: Improvement
>          Components: core-serialization
>    Affects Versions: 2.0.3
>            Reporter: Karel Hübl
>            Assignee: Roger Whitcomb
>             Fix For: 2.0.4, 2.1
>
>         Attachments: patch_trunk_rev1534200
>
>
> We require handling of all uncaught exceptions using standard mechanism (implementing
UncaughtExceptionHandler interface on PivotApplication class).
> Similar to recently resolved https://issues.apache.org/jira/browse/PIVOT-916, it is currently
not possible also in BXMLSerializer class. To resolve this, I would propose to:
> 1) Handle all exception reporting in BXMLSerializer in single protected method to enable
overriding this method in BXMLSerializer descendant. I will upload patch for this.
> 2) Change scope of static ApplicationContext.handleUncaughtException method to public.
This will enable the delegation of exception handling from BXMLSerializer descendants to ApplicationContext.
So hacks like this http://svn.codespot.com/a/apache-extras.org/pivot-contrib/trunk/pivot_contrib.util/src/pivot_contrib/util/serializer/InjectingSerializer.java
wont be required anymore ;-).
> Please let me know, if someone can see more elegant solution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message