pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandro Martini (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PIVOT-689) Finishing touches on Skin Colors
Date Thu, 28 Aug 2014 12:36:08 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112496#comment-14112496
] 

Sandro Martini edited comment on PIVOT-689 at 8/28/14 12:35 PM:
----------------------------------------------------------------

Committed revision 1620944, with a rebalancing and updates to some colors of the default palette
(of Terra Skin), so all is less whitening, but some colors have more saturation now.

Now check the foreground color of labels: it uses the index 1 of palette colors, but now color
1 of default palette is very dark (10,10,10), but not pure black (0,0,0) like palette index
0, so the contrast with backgound is not as max as could be ... but things looks good the
same, so unless objections could be safe to keep it as is.

Tell me for problems or if you don't like these changes.



was (Author: smartini):
Committed revision 1620944, with a rebalancing and updates to some colors of the default palette
(of Terra Skin), so all is less whitening, but some colors have more saturation now.

Now I only have to check the foreground color of labels for using the darker version of first
palette color (pure black now) or the first palette color ... and maybe other small things.
After this, the issue should be ok.

Tell me for problems or if you don't like these changes.


> Finishing touches on Skin Colors
> --------------------------------
>
>                 Key: PIVOT-689
>                 URL: https://issues.apache.org/jira/browse/PIVOT-689
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.1, 2.0.5
>
>         Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - dark.launch,
KitchenSink - Dark.launch, pivot689.patch
>
>
> Finishing touches on Skin Colors, some info here (and  more later here in JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful: https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change some color
index usage to have better visual appearance (of course retrofitting existing behavior when/if
possible).
> Note that probably after these little changes, custom color json files should be a little
updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color) ... what
do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar (yellow-ish
but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to what should
be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not the best
in graphic design and colors :-) ), but with this little change we could also have this little
feature, where in most palettes will be yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette usage in
the Terra Skin, to help anyone wants to write their custom colors, and then removed, probably
the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some Tooltips to
see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, grouping them
by similar components (some componets should be added there).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message