pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandro Martini (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-689) Finishing touches on Skin Colors
Date Wed, 20 Aug 2014 17:00:27 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104124#comment-14104124

Sandro Martini commented on PIVOT-689:

Hi Roger, just Committed revision 1619155 with changes like your proposal ... all should be
ok now, otherwise tell me.

Note that common methods currently are all in ComponentSkin, and no additional methods have
been put in Theme (but they could be) ... if someone thinks methods like defaultBackgroundColor/defaultForegroundColor
could be useful in Theme (maybe because someone could override them in a simpler way), I'll
update/move them there, tell me if needed.

Small note: running some examples in the usual (default) color scheme combination now It seems
to me that the interface is a little too much whitening, tell me if some adjustment is needed.

> Finishing touches on Skin Colors
> --------------------------------
>                 Key: PIVOT-689
>                 URL: https://issues.apache.org/jira/browse/PIVOT-689
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.1, 2.0.5
>         Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - dark.launch,
KitchenSink - Dark.launch, pivot689.patch
> Finishing touches on Skin Colors, some info here (and  more later here in JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful: https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change some color
index usage to have better visual appearance (of course retrofitting existing behavior when/if
> Note that probably after these little changes, custom color json files should be a little
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color) ... what
do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar (yellow-ish
but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to what should
be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not the best
in graphic design and colors :-) ), but with this little change we could also have this little
feature, where in most palettes will be yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette usage in
the Terra Skin, to help anyone wants to write their custom colors, and then removed, probably
the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some Tooltips to
see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, grouping them
by similar components (some componets should be added there).

This message was sent by Atlassian JIRA

View raw message