pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandro Martini (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PIVOT-689) Finishing touches on Skin Colors
Date Fri, 08 Aug 2014 17:29:12 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089475#comment-14089475
] 

Sandro Martini edited comment on PIVOT-689 at 8/8/14 5:27 PM:
--------------------------------------------------------------

Just see that ActivityIndicators (skin component is TerraActivityIndicatorSkin) with the dark
color scheme seems to have a white background (even if backgroundColor is by default set to
null inside it), but the problem seems related to some settings inside Component Explorer,
because when running Kitchen Sink with the same color combination, ActivityIndicators have
a transparent backgound (ok); I'll try to take a look at it in some free time.

No, the problem is that by default WindowSkin has a backgroundColor set to Color.WHITE and
even other base generic components (and they are generic so this is Ok), while TerraFrameSkin
and others Terra components set other colors defined in the theme (ok).

This little thing with ActivityIndicators is visible even running the (just updated) test
file activity_indicator_test.bxml ; try in that file to change Window with Frame and even
background color under ActivityIndicators will change, to demonstrate that it's something
related to the container.

So, to solve this small thing, I have to try in ActivityIndicators to set to null the backgroundColor
of the container (if any) ... if it's possible.



was (Author: smartini):
Just see that ActivityIndicators (skin component is TerraActivityIndicatorSkin) with the dark
color scheme seems to have a white background (even if backgroundColor is by default set to
null inside it), but the problem seems related to some settings inside Component Explorer,
because when running Kitchen Sink with the same color combination, ActivityIndicators have
a transparent backgound (ok); I'll try to take a look at it in some free time.


> Finishing touches on Skin Colors
> --------------------------------
>
>                 Key: PIVOT-689
>                 URL: https://issues.apache.org/jira/browse/PIVOT-689
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.1, 2.0.5
>
>         Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer - dark.launch,
KitchenSink - Dark.launch, pivot689.patch
>
>
> Finishing touches on Skin Colors, some info here (and  more later here in JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful: https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change some color
index usage to have better visual appearance (of course retrofitting existing behavior when/if
possible).
> Note that probably after these little changes, custom color json files should be a little
updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color) ... what
do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar (yellow-ish
but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to what should
be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not the best
in graphic design and colors :-) ), but with this little change we could also have this little
feature, where in most palettes will be yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette usage in
the Terra Skin, to help anyone wants to write their custom colors, and then removed, probably
the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some Tooltips to
see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, grouping them
by similar components (some componets should be added there).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message