pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIVOT-967) JSONSerializer doesn't correctly handle CR characters
Date Wed, 22 Apr 2015 00:09:59 GMT

     [ https://issues.apache.org/jira/browse/PIVOT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Roger Whitcomb updated PIVOT-967:
    Attachment: 967.patch

This "967.patch" is my best guess as to the correct code.  I have tried it in my fail case
situation and everything appears to be correct.  And I think all the comments I have added
are correct as to intent and operation.

> JSONSerializer doesn't correctly handle CR characters
> -----------------------------------------------------
>                 Key: PIVOT-967
>                 URL: https://issues.apache.org/jira/browse/PIVOT-967
>             Project: Pivot
>          Issue Type: Bug
>          Components: core-serialization
>    Affects Versions: 2.0.4, 2.1, 2.0.5
>         Environment: All, but particularly Windows
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.1, 2.0.5
>         Attachments: 967.patch
> The JSON standard (see JSON.org) defines specific escape sequences for the following
characters:  \b, \f, \n, \r, \t and \uxxxx for other control characters.  But the encoding
logic in JSONSerializer doesn't match this list (particularly missing \r and not encoding
other control characters using \uxxxx).  The "writeObject" method only recognizes \t and \n
and does not encode any control character less than 0xFF.  The "readString" method seems a
bit weird also in its handling of control characters in the input.

This message was sent by Atlassian JIRA

View raw message