pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roger and Beth Whitcomb <RogerandB...@rbwhitcomb.com>
Subject Re: svn commit: r1792484 - in /pivot/branches/2.0.x: core/test/org/apache/pivot/serialization/test/StringSerializerTest.java examples/src/org/apache/pivot/examples/scripting/README.txt wtk/src/org/apache/pivot/wtk/LocalManifest.java
Date Mon, 24 Apr 2017 15:35:47 GMT
Yes, I ran the tests again, and everything was okay .... I just remember 
having problems when I first changed the code, but ...

Thanks,

~Roger

On 4/24/17 8:33 AM, Sandro Martini wrote:
> I just remember now that it's a JUnit test class
> (StringSerializerTest.java) so maybe could be save even with that
> change, ok ?
> I run it and seems to work.
>
> Bye
>
>
> 2017-04-24 17:32 GMT+02:00 Sandro Martini <sandro.martini@gmail.com>:
>> Uh sorry, I did some tests and all seems to work the same ... anyway I
>> revert this, no problem :-) .
>>
>>
>> 2017-04-24 17:29 GMT+02:00 Roger and Beth Whitcomb
>> <RogerandBeth@rbwhitcomb.com>:
>>> I actually think that "((int)b[i]) & 0xFF" part was necessary in there, even
>>> though Eclipse may not like it ..... The issue has to do with sign extension
>>> from byte that I don't want for values > 127.....
>>>
>>>
>>> ~Roger
>


Mime
View raw message