pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-734) Branch controls do not update while showEmptyBranchControls=false
Date Mon, 05 Feb 2018 18:42:00 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352749#comment-16352749

Roger Whitcomb commented on PIVOT-734:

So, with the patched change to "loadChildren" it works "pretty well".  The only glitch I
see is in this scenario:
 * Click on "Occasion", click "Add"
 * Make sure the "Occasion" branch is collapsed, then click "Remove"
 * Click "Add" again – the branch control will not show up again until you move the mouse
over the "Occasion" branch (so it repaints with the gray highlight).
 * Note: it works okay, the very first time you click "Add", but there is this strange effect
the second time with branchExpanded set to false.

Also note:  the code for "Remove" was not correct, in that it made a new branch to remove,
which, although it had the same text was NOT the same branch, so TreeBranch.equals was never
true and the branch would not be removed.  So, rework the code to make a single branch to
add or remove.

> Branch controls do not update while showEmptyBranchControls=false
> -----------------------------------------------------------------
>                 Key: PIVOT-734
>                 URL: https://issues.apache.org/jira/browse/PIVOT-734
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk-terra
>    Affects Versions: 2.0
>            Reporter: Brent N Atkinson
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.5
> When showEmptyBranchControls is false, adding items to empty branch nodes does not cause
the UI to include branch controls for the now non-empty branch.
> Using the definition:
> {code}
> <TreeView bxml:id="aTree" styles="{showEmptyBranchControls:false}">
> ...
> </TreeView>
> {code}
> ...adding an item to an empty branch in the tree's data exposes the problem. The expected
behavior is that the node reflects that it is non-empty and the expander controls show up.
The actual behavior is that there is no change in the controls for the node.
> See the user-list thread for details: http://apache-pivot-users.399431.n3.nabble.com/Adding-values-to-TreeView-branch-while-using-showEmptyBranchControls-tp2842044p2842044.html

This message was sent by Atlassian JIRA

View raw message