pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-1011) Move ListenerList implementations of interfaces into the interface itself
Date Thu, 01 Feb 2018 20:34:00 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349208#comment-16349208
] 

Roger Whitcomb commented on PIVOT-1011:
---------------------------------------

I think this is the last of them:

Sending charts\src\org\apache\pivot\charts\ChartView.java
Sending charts\src\org\apache\pivot\charts\ChartViewCategoryListener.java
Sending charts\src\org\apache\pivot\charts\ChartViewListener.java
Sending charts\src\org\apache\pivot\charts\ChartViewSeriesListener.java
Sending tests\src\org\apache\pivot\tests\CalendarTest.java
Sending wtk\src\org\apache\pivot\wtk\Calendar.java
Sending wtk\src\org\apache\pivot\wtk\CalendarBindingListener.java
Sending wtk\src\org\apache\pivot\wtk\CalendarButton.java
Sending wtk\src\org\apache\pivot\wtk\CalendarButtonBindingListener.java
Sending wtk\src\org\apache\pivot\wtk\CalendarButtonListener.java
Sending wtk\src\org\apache\pivot\wtk\CalendarButtonSelectionListener.java
Sending wtk\src\org\apache\pivot\wtk\CalendarListener.java
Sending wtk\src\org\apache\pivot\wtk\CalendarSelectionListener.java
Sending wtk\src\org\apache\pivot\wtk\Menu.java
Sending wtk\src\org\apache\pivot\wtk\MenuBar.java
Sending wtk\src\org\apache\pivot\wtk\MenuBarListener.java
Sending wtk\src\org\apache\pivot\wtk\MenuButton.java
Sending wtk\src\org\apache\pivot\wtk\MenuButtonListener.java
Sending wtk\src\org\apache\pivot\wtk\MenuItemSelectionListener.java
Sending wtk\src\org\apache\pivot\wtk\MenuListener.java
Sending wtk\src\org\apache\pivot\wtk\MenuPopup.java
Sending wtk\src\org\apache\pivot\wtk\MenuPopupListener.java
Sending wtk\src\org\apache\pivot\wtk\MenuPopupStateListener.java
Sending wtk\src\org\apache\pivot\wtk\skin\CalendarButtonSkin.java
Sending wtk\src\org\apache\pivot\wtk\skin\MenuButtonSkin.java
Transmitting file data .........................done
Committing transaction...
Committed revision 1822902.

> Move ListenerList implementations of interfaces into the interface itself
> -------------------------------------------------------------------------
>
>                 Key: PIVOT-1011
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1011
>             Project: Pivot
>          Issue Type: Improvement
>          Components: core-collections, core-util, web, wtk, wtk-terra
>         Environment: All
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>         Attachments: 1011.diffs
>
>
> A universal paradigm in Pivot is to have a "listener" interface for a class or data structure
that is used to notify listeners of changes in the class/data.  There is then an "Adapter"
static class in the interface file that implements the interface with default implementations.
 Then there is a very separate enclosed static class that implements the "ListenerList" interface
of that listener interface.  And usually (or always) this "listener list" class is defined/used
only in the class that needs to notify the listeners.  However, this class must be very parallel
to not only the interface itself, but also the "Adapter" class, and yet it is in a different
place.
> So, it seems somewhat reasonable to move all these "listener list" classes into the interfaces
themselves, so all three related things are located in the same file.  A preliminary POC of
this concept was done with "Query.java", and "QueryListener.java" and it looks good.
> This doesn't seem to require changes to client code, because the accessor methods only
refer to "ListenerList<....>" and not to the listener list class itself (in order to
be more general, of course), but which helps us to hide the implementing class away inside
the interface.
> I will attach the diff of the POC, to hopefully make this more clear.  It may seem a
somewhat nebulous concept, but the idea is to keep "like things" together for clarity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message