pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Whitcomb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
Date Fri, 02 Mar 2018 23:41:00 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384321#comment-16384321
] 

Roger Whitcomb commented on PIVOT-1032:
---------------------------------------

Fixed some more *Test.java files to reduce the "check-style" errors in them:

 
{code:java}
Sending        core/test/org/apache/pivot/util/test/VersionTest.java
Sending        tests/src/org/apache/pivot/tests/WindowFocusTest.java
Sending        tests/src/org/apache/pivot/tests/WindowTest.java
Sending        wtk/test/org/apache/pivot/wtk/test/DimensionsTest.java
Sending        wtk/test/org/apache/pivot/wtk/test/LimitsTest.java
Sending        wtk/test/org/apache/pivot/wtk/test/SpanTest.java
Transmitting file data ......done
Committing transaction...
Committed revision 1825747. 
{code}
 

> Implement "checkstyle" for builds and make changes to bring code into better compliance
> ---------------------------------------------------------------------------------------
>
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>         Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task already
implemented, to do some sort of "checkstyle" processing to evaluate all the code to see where
there might be changes to make the code more robust and a better example of "canonical" Java
style.
> I hesitate to expect that we could address everything (or indeed whether we *should*),
but there might be things that would make the code better and easier to read and maintain,
and wouldn't take much effort.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message