pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Lee Whitcomb (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
Date Fri, 27 Aug 2021 06:43:00 GMT

    [ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405629#comment-17405629
] 

Roger Lee Whitcomb edited comment on PIVOT-1032 at 8/27/21, 6:42 AM:
---------------------------------------------------------------------

PIVOT-1032: In the StyleChecks program, make sure the file names for the "-f" parameter actually
exist,
and that the categories for "-c" are actually tested in our style file. Also fix a bug due
to duplicate
file names in different subtrees that caused counts to be off between the top list and the
final counts.

Sending        StyleChecks.java
Transmitting file data .done
Committing transaction...
Committed revision 1892628.

Actually there are still a few glitches even after this fix: if there are duplicate names,
within a category the names will get disambiguated, but between categories they do not. Also,
the "-f" processing won't find names with leading paths, so you can't actually filter by "wtk/text/Element"
like you need to for the duplicate case.


was (Author: rwhitcomb):
PIVOT-1032: In the StyleChecks program, make sure the file names for the "-f" parameter actually
exist,
and that the categories for "-c" are actually tested in our style file. Also fix a bug due
to duplicate
file names in different subtrees that caused counts to be off between the top list and the
final counts.

Sending        StyleChecks.java
Transmitting file data .done
Committing transaction...
Committed revision 1892628.

> Implement "checkstyle" for builds and make changes to bring code into better compliance
> ---------------------------------------------------------------------------------------
>
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Lee Whitcomb
>            Assignee: Roger Lee Whitcomb
>            Priority: Minor
>             Fix For: 2.1.0
>
>         Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task already
implemented, to do some sort of "checkstyle" processing to evaluate all the code to see where
there might be changes to make the code more robust and a better example of "canonical" Java
style.
> I hesitate to expect that we could address everything (or indeed whether we *should*),
but there might be things that would make the code better and easier to read and maintain,
and wouldn't take much effort.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message