plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christofer Dutz <christofer.d...@c-ware.de>
Subject [CANCELLED] [VOTE] Apache PLC4X 0.7.0 RC1
Date Tue, 19 May 2020 15:43:46 GMT
I am canceling the RC and fixing the stuff we found to make a perfect RC2 :)



Am 18.05.20, 18:15 schrieb "Otto Fowler" <ottobackwards@gmail.com>:

     https://gist.github.com/ottobackwards/7f40865c5a1dad8b09c06c5215f40bd8

    The error.  Chris has reproduced.

    java -version
    java version “1.8.0_171"
    Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
    Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)




    On May 18, 2020 at 11:33:49, Otto Fowler (ottobackwards@gmail.com) wrote:

    -1 binding.

    Does not build with java 8 as documented.
    The rest seems fine.



    On May 18, 2020 at 05:55:31, Christofer Dutz (christofer.dutz@c-ware.de)
    wrote:


    +1 Binding

    Chris


    [OK] Download all staged artifacts under the url specified in the release
    vote email into a directory we’ll now call download-dir.
    [OK] Verify the signature is correct: Additional Apache tutorial on how to
    verify downloads can be found here.
    [OK] Check if the signature references an Apache email address.
    [OK] Verify the SHA512 hashes:
    [OK] Unzip the archive:
    [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files
    in the extracted source bundle.
    [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in
    the extracted source bundle.
    [OK] [RM] Verify the staged source README, RELEASE_NOTE files correspond to
    those in the extracted source bundle.
    [OK] [RM] Run RAT externally to ensure there are no surprises.
    [OK] Search for SNAPSHOT references: Only found in commented out
    dependencies and disabled parts of the project (Parts not yet deleted)
    [OK] Search for Copyright references, and if they are in headers, make sure
    these files containing them are mentioned in the LICENSE file: No findings
    in a bad form, however it seems some files use other apache headers as
    others (Some files have apache headers containing the word "copyright" but
    most don't)
    [MINOR]Build the project according to the information in the README.md
    file: One example references a module in the sandbox, so the "with-sandbox"
    profile needs to be enabled in addition)
    [OK] [RM] Build the project with all with-xyz profiles and tests enabled
    and an empty maven local repo: by appendng -Dmaven.repo.local=../.m2.



    Am 17.05.20, 19:39 schrieb "Robinet, Etienne" <43823@etu.he2b.be>:

    Hi Chris,
    +1
    Checklist:
    - Download all staged artifacts under the url specified in the release vote
    email
    - Verify the signature is correct
    - Check if the signature references an Apache email address.
    - Verify the SHA512 hashes
    - Unzip and verify existence and content of LICENSE, NOTICE, README,
    RELEASE_NOTES
    - Run RAT externally to ensure there are no surprises (also 7 unknown
    Licences)

    apache-plc4x-0.7.0/build-utils/protocol-base-mspec/src/main/antlr4/org/apache/plc4x/plugins/codegenerator/language/mspec/expression/Expression.g4


    apache-plc4x-0.7.0/build-utils/protocol-base-mspec/src/remote-resources/UNLICENSE

    apache-plc4x-0.7.0/licenses/UNLICENSE
    apache-plc4x-0.7.0/plc4j/examples/hello-webapp/client/asconfig.json
    apache-plc4x-0.7.0/plc4j/tools/scraper/src/test/resources/config.json
    apache-plc4x-0.7.0/sandbox/code-gen/src/main/resources/example.json
    apache-plc4x-0.7.0/sandbox/code-gen/src/main/resources/example2.json
    -Search for "SNAPSHOT" and "Copyright" reference
    - Build the project according to the information in the README.md
    file(./mvnw -P with-sandbox install)

    OS: Windows 10 Pro.
    Java: OpenJDK 11.0.2
    Maven: 3.6.0

    Etienne

    Le dim. 17 mai 2020 à 11:31, Julian Feinauer <j.feinauer@pragmaticminds.de>
    a écrit :

    > Hi,
    >
    > my vote is +1 (binding).
    >
    > I did:
    > - Download all artefacts
    > - Checked Signatures and Hashes
    > - Checked staged README and RELEASE NOTES is similar to Version in Repo
    > - Checked content of README, RELEASE_NOTES, NOTICE and LICENSE (Minor:
    > References 0.7.0 as Snapshot)
    > - Checked no unexpected binaries
    > - Build project according to docu (macOS)
    >
    > Thank you for the work Chris, well done!
    > Julian
    >
    > Am 16.05.20, 23:58 schrieb "Cesar Garcia" <cesar.garcia@ceos.com.ve>:
    >
    > Hi Chris,
    >
    > 1+
    >
    > 1. Download all staged artifacts under the url specifie, OK
    > 2. Verify the signature is correct , OK
    > 3. Check if the check is successful. OK
    > 4. Check if the signature references an Apache email address. OK
    > 5. Verify the SHA512 hashes: OK
    > 6. Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES
    > files in
    > the extracted source bundle. OK
    > 7. Run RAT externally to ensure there are no surprises. OK, but 7
    > Unknown
    > Licenses.
    > 8. Search for SNAPSHOT references: OK
    > ./plc4j/drivers/ads/pom.xml
    > ./plc4j/examples/dummy-driver/pom.xml
    > ./plc4j/examples/hello-webapp/client/pom.xml
    > ./plc4j/examples/hello-webapp/pom.xml
    > ./plc4j/examples/hello-webapp/webapp/pom.xml
    > ./plc4j/examples/pom.xml
    > ./plc4j/integrations/apache-camel/pom.xml
    > ./plc4j/integrations/apache-edgent/pom.xml
    > ./plc4j/integrations/apache-kafka/pom.xml
    > ./plc4j/integrations/apache-nifi/nifi-plc4x-nar/pom.xml
    > ./plc4j/integrations/logstash-plugin/pom.xml
    > ./plc4j/karaf-features/camel/pom.xml
    > ./plc4j/karaf-features/eip/pom.xml
    > ./plc4j/karaf-features/karaf-itest/pom.xml
    > ./plc4j/karaf-features/pom.xml
    > ./plc4j/karaf-features/s7/pom.xml
    > ./plc4j/protocols/ads/pom.xml
    > ./plc4j/protocols/benchmarks/pom.xml
    > ./plc4j/protocols/delta-v/pom.xml
    > ./plc4j/protocols/pom.xml
    >
    > 9. Search for Copyright references, and if they are in headers, make
    > sure
    > these files containing them are mentioned in the LICENSE file., OK
    > 10. Build the project according to the information in the README.md
    > file.
    > Using: ">mvn -P with-sandbox install", OK
    >
    >
    > OS: Windows 10 Pro.
    > Java: openjdk 11.0.4 2019-07-16
    > Maven: openjdk 11.0.4 2019-07-16
    >
    >
    >
    > El vie., 15 may. 2020 a las 12:52, Christofer Dutz (<
    > christofer.dutz@c-ware.de>) escribió:
    >
    > > Apache PLC4X 0.7.0 has been staged under [2] and it’s time to vote
    > > on accepting it for release. All Maven artifacts are available under
    > [1].
    > > Voting will be open for 72hr.
    > >
    > > A minimum of 3 binding +1 votes and more binding +1 than binding -1
    > > are required to pass.
    > >
    > > Release tag: release/0.7.0
    > > Hash for the release tag: c06b73473383405a550ac4f4cee7dd8636325a35
    > >
    > > Per [3] "Before voting +1 PMC members are required to download
    > > the signed source code package, compile it as provided, and test
    > > the resulting executable on their own platform, along with also
    > > verifying that the package meets the requirements of the ASF policy
    > > on releases."
    > >
    > > You can achieve the above by following [4].
    > >
    > > [ ] +1 accept (indicate what you validated - e.g. performed the
    > non-RM
    > > items in [4])
    > > [ ] -1 reject (explanation required)
    > >
    > >
    > > [1]
    > https://repository.apache.org/content/repositories/orgapacheplc4x-1027
    > > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.7.0/rc1
    > > [3] https://www.apache.org/dev/release.html#approving-a-release
    > > [4] https://plc4x.apache.org/developers/release/validation.html
    > >
    > >
    > >
    >
    > --
    > *CEOS Automatización, C.A.*
    > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
    > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*
    >
    > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
    > *Ing. César García*
    >
    > *Cel: +58 414-760.98.95*
    >
    > *Hotline Técnica SIEMENS: 0800 1005080*
    >
    > *Email: support.aan.automation@siemens.com
    > <support.aan.automation@siemens.com>*
    >
    >

Mime
View raw message